Former Hillary Adviser: "Hillary will run again. She will not allow this humiliating loss at the hands of an amateur to end the story of her career.”

magnora7 · 2018-11-12T18:50:25+00:00

Yeah that's the worst part, is she's apparently going to do it out of personal spite, rather than to try and better the country.

magnora7 · 2018-11-11T23:36:12+00:00

Haha glad we see things similarly. I can't get in to DS9, they never go anywhere, it's always on this space station. Everything is baseball analogies for Jake and protracted foreign politics discussions that don't affect the non-moving space station. At least in Voyager they're always just trying to get back home. I find that more interesting.

magnora7 · 2018-11-11T23:32:05+00:00

Ah ok, good to know, thanks. I just figured from its folder location that it's unused.

magnora7 · 2018-11-11T22:00:48+00:00

Fixed. The cookie is now named saidit_session. Thanks for the bug report!

magnora7 · 2018-11-11T22:00:17+00:00

Sweet. Just finished updating everything in post_tests.py and tracker.py (which I'm pretty certain is not being used at all). That's it! Should be good to go.

magnora7 · 2018-11-11T21:51:00+00:00

Cool. Alright I changed the development.update to include this in the general section:

login_cookie = saidit_session

name of the admin cookie

admin_cookie = saidit_admin

name of the otp cookie

otp_cookie = saidit_otp

then did make ini, flush, and restart. Seems to still work. I don't think it's storing cookies because of the certificate not existing?

I'm going to try it out on saidit now, and then I'll change those two python references.

magnora7 · 2018-11-11T21:32:07+00:00

I'd say that the names of these cookies are not user facing, so this is less of a branding issue and more of a philosophical issue.

Yeah I was thinking the same at first, but honestly this is different from the database. Some people do go through their cookies, but no one will ever see internal variables. I think if people other than us can see it, we should change it. And this guy found this cookie instance, so I think we should change it. If it's really as easy as changing those 3 instances, I think we should do it. If it's some 2 hour process, then we could skip it, I don't think it's worth dedicating a lot of time to. But let's try the easy way and see if it works to fix it. If it doesn't, we'll re-evaluate.

Changing all these instances has a couple good consequences:

Branding, to show saidit is polished and finished for the user as much as possible.
If someone wants to deploy saidit on their own server, they can simply find and replace saidit with something else. We weren't able to do that with reddit because the name is embedded in all these random variables, but someone could do that with saidit. So we're creating a package that can be easily re-branded for others to deploy if they want. Unlike the reddit code.
The cookie stored on the user's computer should have the correct site name on it, just for security and trust reasons. It's the only file we really store on their computer, so let's at least name it correctly

Those are my reasons why it's worth it, even though it seems like a small issue. Still worth 15 mins of trying, but not worth hours and hours. I have no desire to rename anything that isn't customer-facing, but this cookie is, imo. I would consider html and css code labels as not customer-facing. And database stuff is definitely not customer-facing.

If it's going to break RES or the mobile stuff, then it should contain the text "reddit_session" somewhere. If it doesn't, we should be good to go.

So we can just change all 3 of those instances (adding the line to development.update), then do 'make ini' right? Then that's it? I guess I'll try it on the dev server first, might as well.

magnora7 · 2018-11-11T21:23:25+00:00

lol I love the random shade thrown toward the /r/videos mods

magnora7 · 2018-11-11T20:49:28+00:00

Nah spez committed in reddit, not reddit-ae. Only me and d3rr have worked on reddit-ae (ae standing for AntiExtremes.com which used to be the name of saidit)

magnora7 · 2018-11-11T20:48:12+00:00

reddit-ae was forked about a year and a half ago, but the original reddit repository it's based on stopped being updated in 2015.

I think the custom themes have been around for at least 8 years, I'd guess. Probably about the time Aaron Swartz was there.

magnora7 · 2018-11-11T20:45:02+00:00

Nice. I could imagine this one being in Tony Hawk Pro Skater 7 or something haha

magnora7 · 2018-11-11T20:38:39+00:00

TNG > Voyager > DS9 > Original series > Enterprise > Movies

magnora7 · 2018-11-11T20:32:14+00:00

I appreciate you taking the time to lay out your argument so clearly. You make a good point about being able to vote both... so basically you think in people's desire to add more points to something they like that isn't funny, they'll use the funny vote to promote it more? I see what you mean now.

On the one hand that's kind of also laughing at content they're trying to seriously promote, so I don't know if people would do that. Plus anyone truly dedicated to gaming the vote system can just switch between multiple accounts, so I'm not sure how much it's actually preventing in reality.

We put a lot of work in to coding the functionality of being able to vote both. It'd be a real shame to undo all that, plus it's one of the unique features to saidit.

What if we met in the middle? What if insightful is +2, funny +1, but then if you vote both it's still just +2 total, but it gives +1 to the insightful category and +1 to the funny category? This way it doesn't give additional points, but still gives the diversity of indication of being able to vote multiple ways. That way it doesn't encourage voting funny for visibility, but the complexity of the voting system is still maintained.

I think we would definitely consider a system like this, it makes a lot of sense.

magnora7 · 2018-11-11T19:44:13+00:00

There is no better system though. The votes have to come from somewhere... at some point we have to trust the user or there would be no voting at all. People can still be removed if they're bringing the quality of saidit down as per the pyramid of debate. What is your proposed solution?

magnora7 · 2018-11-11T19:20:25+00:00

Thanks for the report. Is it the name of the cookie, or something within the cookie? This one could be a pain to rename... /u/d3rr what do you think about this one

edit: It looks like it's a development.ini setting, maybe we can just change it in the development.update file and make ini and that'll solve it?

edit2: There are also mentions of "reddit_session" in post_tests.py and tracker.py. We're probably not even using the one in tracker, but we can change those both too to saidit_session and that should get everything?

magnora7 · 2018-11-11T19:17:57+00:00

Anything highlighted becomes a quote in your reply when you hit the reply button. So you must've had "white-bulbed" highlighted.

I don't want them to be equal, because I want insightful things prioritized over funny things, because I don't want this site to become reddit.

Plus you can still vote both, so having them the same score wouldn't reduce people gaming the system if someone chose to do so.

magnora7 · 2018-11-11T19:05:29+00:00

Was it funny? then why vote it funny? They're sorted differently...

magnora7 · 2018-11-11T10:15:38+00:00

Yeah? Of course some will abuse it, but most won't and it'll still be a useful thing

magnora7 · 2018-11-11T09:25:44+00:00

What do you mean exactly?

magnora7 · 2018-11-11T08:35:00+00:00

Sometimes funny things are insightful, sometimes they aren't. Just vote with what feels right.

magnora7 · 2018-11-11T04:27:02+00:00

I can see it, I'm not big in to that type of use personally because it still promotes the content higher on the front page, so it's not really effective as a protest vote.

magnora7 · 2018-11-10T22:28:52+00:00

But the/a true rebellion against the system he doesn't preach

he is preaching against changes he finds not correct to the system, but still fully endorsing the system.

I mean... not really. He's pretty against post-modernism, and says it has taken over the culture and academia, and is openly against this.

There's various levels of changing the system, and I could agree he's on the more tame side of things, but he still is calling for deep change in a lot of ways.

Imo there is no "true rebellion against the system", it's all shades of grey. Some could make the argument that being happy within yourself for who you are is the truest rebellion in a system looking to control us with fear and conformity.

magnora7[A]

MODERATOR OF

name of the admin cookie

name of the otp cookie