you are viewing a single comment's thread.

view the rest of the comments →

[–]useless_aether 4 insightful - 1 funny4 insightful - 0 funny5 insightful - 1 funny -  (24 children)

this night mode is so awesome.

will the irc window stay the same?

[–]magnora7[S] 3 insightful - 1 funny3 insightful - 0 funny4 insightful - 1 funny -  (23 children)

Glad you like it!

It looks like all the CSS for the irc window is part of an iframe that uses CSS that is pulled from the lounge servers, so we don't actually have that CSS I think. I don't know how much is changeable. I was trying to change the thick black border around the chat window, and I couldn't find the CSS for it anywhere in any of our files anywhere on the server, so I'm pretty sure it's pulling it from the lounge.

[–]d3rr 3 insightful - 1 funny3 insightful - 0 funny4 insightful - 1 funny -  (22 children)

The Lounge has a dark theme, you can turn it on in your Lounge settings, inside the iframe. It's not as nice as the default from what I remember. We can use that as the default in night mode, or release our own night mode theme to use as the default.

We are hosting all of this, the css is somewhere in home/lounge-autoconnect.

[–]magnora7[S] 3 insightful - 1 funny3 insightful - 0 funny4 insightful - 1 funny -  (21 children)

Oh cool, let's turn it on and try it out and see if it matches what we have.

Oh okay, maybe I didn't look in home/lounge-autoconnect, you're probably right

[–]d3rr 3 insightful - 1 funny3 insightful - 0 funny4 insightful - 1 funny -  (20 children)

It matches pretty good. You can demo it yourself now by choosing theme "Zenburn" in TheLounge. (hamburger menu, then settings cog icon at the bottom left, below the channel list).

[–]magnora7[S] 3 insightful - 1 funny3 insightful - 0 funny4 insightful - 1 funny -  (19 children)

Yeah that does work well! I like it.

[–]d3rr 3 insightful - 1 funny3 insightful - 0 funny4 insightful - 1 funny -  (18 children)

Okay, Zenburn is now the default theme for the chat client. The theme setting is stored in browser localStorage though, so existing users need to do a full cache clear to actually have it change. But I guess eventually everyone will have it.

[–]magnora7[S] 3 insightful - 1 funny3 insightful - 0 funny4 insightful - 1 funny -  (0 children)

Sweet. Sounds good. Nice work.

[–]magnora7[S] 3 insightful - 1 funny3 insightful - 0 funny4 insightful - 1 funny -  (16 children)

Okay I'm done for tonight. I got stuck on one, https://saidit.net/search?q=asdfs

The search bar text is black. I can not for the life of me figure out where in the .less files to change it. For some reason the "#search input[type=text] " category where i would think I would define the color ends up not working for some reason I can't figure out, I tried for like an hour. It's a pretty minor thing, but other than that I think it's all good. It's just that squirrely one thing.

[–]d3rr 3 insightful - 1 funny3 insightful - 0 funny4 insightful - 1 funny -  (15 children)

nice work man! the site looks great.

those dirty birds hardcoded it into the template: https://github.com/libertysoft3/reddit-ae/blob/11857b0373d509ac11716874786f0a1dc67856d3/r2/r2/templates/searchform.html#L58

inline styles override everything, we should edit the template and remove that part.

[–]magnora7[S] 3 insightful - 1 funny3 insightful - 0 funny4 insightful - 1 funny -  (14 children)

Jesus fucking christ. Thank you.

I fixed it in 5 seconds now that you pointed that out. The intended settings were getting overwritten by a hardcoded style="color:black" in there. God damn! Glad that's resolved, I was beginning to go mad trying to trace that one down.

Cool, so that's everything! Let me know if you spot any more. I'm probably calling it a night now that I have a CSS-induced headache lol

edit: I keep thinking of this, lol https://bethesignal.org/wp-content/uploads/2009/06/css-is-awesome-700x375.jpg