Night mode

submitted by magnora7 from self.SaidIt

sorted by:
top
newinsightfulfun
you are viewing a single comment's thread.

view the rest of the comments →

[–]magnora7[S] 3 insightful - 1 fun3 insightful - 0 fun4 insightful - 1 fun -  (19 children)

Yeah that does work well! I like it.

[–][deleted] 3 insightful - 1 fun3 insightful - 0 fun4 insightful - 1 fun -  (18 children)

Okay, Zenburn is now the default theme for the chat client. The theme setting is stored in browser localStorage though, so existing users need to do a full cache clear to actually have it change. But I guess eventually everyone will have it.

[–]magnora7[S] 3 insightful - 1 fun3 insightful - 0 fun4 insightful - 1 fun -  (0 children)

Sweet. Sounds good. Nice work.

[–]magnora7[S] 3 insightful - 1 fun3 insightful - 0 fun4 insightful - 1 fun -  (16 children)

Okay I'm done for tonight. I got stuck on one, https://saidit.net/search?q=asdfs

The search bar text is black. I can not for the life of me figure out where in the .less files to change it. For some reason the "#search input[type=text] " category where i would think I would define the color ends up not working for some reason I can't figure out, I tried for like an hour. It's a pretty minor thing, but other than that I think it's all good. It's just that squirrely one thing.

[–][deleted] 3 insightful - 1 fun3 insightful - 0 fun4 insightful - 1 fun -  (15 children)

nice work man! the site looks great.

those dirty birds hardcoded it into the template: https://github.com/libertysoft3/reddit-ae/blob/11857b0373d509ac11716874786f0a1dc67856d3/r2/r2/templates/searchform.html#L58

inline styles override everything, we should edit the template and remove that part.

[–]magnora7[S] 3 insightful - 1 fun3 insightful - 0 fun4 insightful - 1 fun -  (14 children)

Jesus fucking christ. Thank you.

I fixed it in 5 seconds now that you pointed that out. The intended settings were getting overwritten by a hardcoded style="color:black" in there. God damn! Glad that's resolved, I was beginning to go mad trying to trace that one down.

Cool, so that's everything! Let me know if you spot any more. I'm probably calling it a night now that I have a CSS-induced headache lol

edit: I keep thinking of this, lol https://bethesignal.org/wp-content/uploads/2009/06/css-is-awesome-700x375.jpg

[–][deleted] 2 insightful - 1 fun2 insightful - 0 fun3 insightful - 1 fun -  (13 children)

hahahhaa, love that cup

[–]magnora7[S] 1 insightful - 1 fun1 insightful - 0 fun2 insightful - 1 fun -  (12 children)

D3rr, what do you think about this thread:

https://saidit.net/r/newSubreddit/comments/kl/roseville_concrete_home_construction/

The person just basically created a username to make an ad for their company website on our site. I guess that's fine, depending on the sub, right? I've thought about trolls but I hadn't thought about advertisers. My impulse is to ignore it, but i'm also worried about preserving the quality of the content on the site, but perhaps that's what the votes are for.

The only things that really need removed are porn, and stuff that's just really gross or just hateful and divisive without reason. Trolling stuff.

Ad stuff... well... I guess we can just let it slide? I doubt this person will be posting ads every day or anything. But we should probably come up with some game plan for people using this as an ad board. Perhaps we could make a sub /r/ads and force them to post there if they're going to post ads or something like that, rather than just censor/delete them outright. Just thinking out loud, you have any thoughts?

[–][deleted] 2 insightful - 1 fun2 insightful - 0 fun3 insightful - 1 fun -  (11 children)

Tough one. I like the idea of creating /r/ads as a safe space for advertisers. Aside from that though, I'd leave it up to individual subs. As you have most of the big subs, for that I'd recommend an "Ad" flair/tag, so that you are calling them out but not censoring/removing. I guess in another system you could move all ads to /r/ads, but you can't really move content here.

Maybe spam/high volume ads is another use case where we should ban and delete the posts.

I do think voting solves this mostly although maybe that changes if downvote goes away.

[–]magnora7[S] 2 insightful - 1 fun2 insightful - 0 fun3 insightful - 1 fun -  (10 children)

Good ideas. We'll just let the voting handle it for now. If it becomes a recurring problem we'll set up one of those solutions you mentioned.

[–][deleted] 2 insightful - 1 fun2 insightful - 0 fun3 insightful - 1 fun -  (9 children)

there's 2 new ads today in /r/news