you are viewing a single comment's thread.

view the rest of the comments →

[–]JasonCarswell[S] 2 insightful - 1 fun2 insightful - 0 fun3 insightful - 1 fun -  (10 children)

/u/magnora7 /u/d3rr

I'm guessing there's something wrong with my CSS code that there is no linked image, other than the thumbnail - the opposite of what was happening on a M7 sub earlier this week.

The same happened here, no image: /s/ElectionsUSA2020/comments/bs2/election_usa_2020_candidates_the_pros_and_cons_of/

Also, I've noticed that the 2018 SaidIt logo is on some of my subs and not on others - through no control of mine. This is perplexing as I've copy/pasted all the identical CSS.

[–][deleted] 2 insightful - 1 fun2 insightful - 0 fun3 insightful - 1 fun -  (2 children)

Large images in the image expando thing only appear for image posts (a link to an imgur .jpg). Thumbnails always happen if the Reddit code can find one and the sub has the setting on to show them.

As for your disappearing logo, make sure it is uploaded to all of the subs, and not just referenced by css. The image links in css always assume "this sub".

[–]JasonCarswell[S] 2 insightful - 1 fun2 insightful - 0 fun3 insightful - 1 fun -  (1 child)

I looked and this image had weird code.

Another linked to a gif that didn't show.

Another, The Steel House had embedded image in some code thing.

It's not my logo that disappeared. It's your old logo. I have no say if it stays or goes that I know of. I'd rather have a say. I'd be happy to embed the old or new logo on all my banners if you guys want me too, but I'd place them in my preferred place aesthetically and design the banners around them.

[–][deleted] 2 insightful - 1 fun2 insightful - 0 fun3 insightful - 1 fun -  (0 children)

I'll check this out sometime, not at my desktop can't do much.

[–]magnora7 2 insightful - 1 fun2 insightful - 0 fun3 insightful - 1 fun -  (6 children)

Sorry I don't have time to debug your CSS code. Too many other things to focus on

[–]JasonCarswell[S] 1 insightful - 1 fun1 insightful - 0 fun2 insightful - 1 fun -  (5 children)

Turns out it's not my code.

It's SaidIt's.

[–]magnora7 2 insightful - 1 fun2 insightful - 0 fun3 insightful - 1 fun -  (4 children)

Well it obviously has to do with the banner images you're using or something? I don't know why you think it's saidit's code when the only thing that changes is your code and your banner

[–]JasonCarswell[S] 1 insightful - 1 fun1 insightful - 0 fun2 insightful - 1 fun -  (3 children)

I can't control whether SaidIt displays GIFs or embedded images.

I haven't controlled the SaidIt logo or where it's placed, but the SaidIt logo does disappear with the implementation of the code for day-night theme banners from /s/Internet :

.theme-daymode #header { background-image: url(%%Saidit-2019-Logo-Day-Banner-2200x140%%); }

.theme-nightmode #header { background-image: url(%%Saidit-2019-Logo-Night-Banner-2200x140%%); }

#header-img, #header-img.default-header { background-image: none; min-height: 90px; }

.theme-daymode #header { background-color: #9999AA; }

.theme-nightmode #header { background-color: #333333; }

Compared to the old code :

#header-bottom-left { height: 50x; padding-top: 168px; background: url(%%Saidit-2019-Logo-Night-2200x300%%) no-repeat; background-position: 50%  }

[–]magnora7 2 insightful - 1 fun2 insightful - 0 fun3 insightful - 1 fun -  (2 children)

I dunno man, you'll just have to figure it out, this is kind of your thing. If you can actually resolve it to a saidit code error, and correct it in the open source, we'll update the code with your changes.

[–]JasonCarswell[S] 1 insightful - 1 fun1 insightful - 0 fun2 insightful - 1 fun -  (1 child)

d3rr is aware of the image issue. I don't think it's really a priority but it is good to know about when posting images or to sites with embedded image coding.

I don't know about the logo issue.

[–]magnora7 2 insightful - 1 fun2 insightful - 0 fun3 insightful - 1 fun -  (0 children)

Well thanks for the feedback, but like you said it's not a priority right now, it's a bit of a niche situation as far as the site in general is concerned. But if you happen to figure it out, let me know.