JS SVG test

submitted by wizzwizz4 from self.wizzwizz4_css_test_1

sorted by:
top
newinsightfulfun
you are viewing a single comment's thread.

view the rest of the comments →

[–][deleted] 1 insightful - 1 fun1 insightful - 0 fun2 insightful - 1 fun -  (13 children)

It looks like you're right, no internal js is run if rendered as an <img>

[–]wizzwizz4[S] 1 insightful - 1 fun1 insightful - 0 fun2 insightful - 1 fun -  (12 children)

So, add? (Please please please?) 🥺

[–][deleted] 1 insightful - 1 fun1 insightful - 0 fun2 insightful - 1 fun -  (11 children)

Alright, it's on our Todo list. I'll show you where the relevant code is if you're so inclined.

[–]wizzwizz4[S] 3 insightful - 1 fun3 insightful - 0 fun4 insightful - 1 fun -  (10 children)

That'd be great; I can't actually find it right now (assuming it's Python).

Edit: https://github.com/libertysoft3/saidit/blob/master/r2/r2/public/static/js/expando-md.js

Edit #2: https://github.com/libertysoft3/saidit/pull/9

[–][deleted] 2 insightful - 1 fun2 insightful - 0 fun3 insightful - 1 fun -  (1 child)

Nice work! Supporting more url formats was a boss change too. I'll get around to adding this same image support for saidit posts proper too.

/u/magnora7 check it out the wizz added .svg support.

https://dev.w3.org/SVG/tools/svgweb/samples/svg-files/mudflap.svg

https://dev.w3.org/SVG/tools/svgweb/samples/svg-files/json.svg

You can embed rasters in vectors? Hmm..

https://dev.w3.org/SVG/tools/svgweb/samples/svg-files/image.svg

[–]magnora7 2 insightful - 1 fun2 insightful - 0 fun3 insightful - 1 fun -  (0 children)

Wow that's great! I love it when other users contribute code and add more functionality. I thanked them for it, that's awesome

[–]magnora7 1 insightful - 1 fun1 insightful - 0 fun2 insightful - 1 fun -  (7 children)

Hey nice coding wizzwizz, solid job! Very much appreciate the added functionality, and I'm sure the users will too. Thank you. We're proud to have more code contributions to the site by users like you.

[–]wizzwizz4[S] 1 insightful - 1 fun1 insightful - 0 fun2 insightful - 1 fun -  (6 children)

Adding your wishlist to GitHub Issues, and maybe setting up a Project Board or two would help to permit contributions.

[–]magnora7 1 insightful - 1 fun1 insightful - 0 fun2 insightful - 1 fun -  (5 children)

We have a huge to-do list we've been working off of for over a year, but it's visible to the admins only. The problem with putting all our bugs on display is that it might open us up to attacks and give trolls ammo to mess with the site.

[–]wizzwizz4[S] 1 insightful - 1 fun1 insightful - 0 fun2 insightful - 1 fun -  (4 children)

Post the small bugs and the feature-requests; they'll be done in no time.

[–]magnora7 2 insightful - 1 fun2 insightful - 0 fun3 insightful - 1 fun -  (3 children)

That's not a bad idea. We might start doing this. I'll have to look through the to-do list though and see what's left.

Tbh we've already solved most of the small bugs. Feature requests would definitely be a good idea though, no security risk there.

Here's 3 features we're going to work on very soon, if you (or anyone else wants to help)

  1. The "unsubscribe to all subs" button that is currently in user preferences, also put that on the user sub management page

  2. The algorithm for limiting how frequently new users can post and comment is too strict and we want to loosen it slightly by allowing for several more posts to be made before the "You are doing this too much, wait 9 mins" dialog comes up.

  3. NSFW posts do not appear in the listings for users not logged in. We want to change it so they do appear for everyone (but the thumbnail will still be fuzzed out)

Those 3 are basically my little projects for the next few days, but if you or anyone wants to take a stab at them, by all means...

I might make this a more official announcement for everyone to see. This is a pretty good idea. Thanks!

[–]wizzwizz4[S] 1 insightful - 1 fun1 insightful - 0 fun2 insightful - 1 fun -  (2 children)

For 3, by "in listings" I assume you aren't counting /s/all. Although I'm struggling to see what the NSFW tag would be used for in the first place, if not porn. (On second thoughts, I don't think I want to know.)

Those feature requests seem adequately possible-but-non-trivial to outsource. I might have a stab at 2, if I find the time.