Time 'till live, ideas for the future

submitted by magnora7 from self.AntiExtremes

sorted by:
top
newinsightfulfun
you are viewing a single comment's thread.

view the rest of the comments →

[–][deleted] 2 insightful - 1 fun2 insightful - 0 fun3 insightful - 1 fun -  (32 children)

Nice! I know I've slowed down a bit but I have been in progress with the chat. I hope to update it here tonight. Love your header artwork and logo. If you want to work towards RESAE in the app stores, you could register for accounts and get all set while I prepare the releases.

[–]magnora7[S] 1 insightful - 1 fun1 insightful - 0 fun2 insightful - 1 fun -  (31 children)

Sounds good. Glad to hear you like the artwork, I was hoping you would! I'll look in to the app store stuff.

[–][deleted] 2 insightful - 1 fun2 insightful - 0 fun3 insightful - 1 fun -  (30 children)

So the first stab at 5. and 6. is done. I forgot about your other comment, so for now the chat summoning text is "!chat_widget" (with two exclamations). I'd be happy to change that.

Have a spin and let's see if it can be improved.

Known issue: guests chat as different guests if multiple chats load at once. Try in incognito: https://antiextremes.com/r/newSubreddit/comments/4m/chat_test/

Known issue: this same link is failing for me as a logged in user. I think multiple on the same page sometimes works if you only join a single new channel. So the same page loading different channels case is quite a bit different and potentially harder than the multiple tab case. If this can't be easily improved we might have to consider "click to load chat" everywhere but the sidebar, and then they don't all load at once.

Maybe subreddit settings should have more options too, like sidebar chat on/off, post and comments chat on/off

Also notice there are "open chat in new tab" links everywhere it shows and new chat user preferences.

[–]magnora7[S] 1 insightful - 1 fun1 insightful - 0 fun2 insightful - 1 fun -  (18 children)

So it was working awesome, and then I tried to create a !chat_widget beneath your functioning one in that link, and then it broke all the chat windows and is asking me to log in to the Lounge. Is there a limit to how many channels you can create? Does creating a chat window in reply to a chat window break it? Or maybe the settings are wrong so it doesn't work in the first place except when you do it?

Anyway, it was working great, other than it seemed to see me as a guest in the !chat_widget you created, instead of as magnora7, and now it's logged out of the lounge because I made a new one.

Is the lounge username and password just one for the whole site to make the app function, or does each user have their own login and password with the Lounge?

[–][deleted] 2 insightful - 1 fun2 insightful - 0 fun3 insightful - 1 fun -  (17 children)

Is there a limit to how many channels you can create?

Not that I'm aware of.

Does creating a chat window in reply to a chat window break it?

It shouldn't

You can log yourself out of chat if you change your irc password... (since you didn't have a default chat password you can delete the password, logout and login to reddit and that might fix. if still not working, try changing chat username to magnora7-1)

[–]magnora7[S] 1 insightful - 1 fun1 insightful - 0 fun2 insightful - 1 fun -  (16 children)

Oh hey it worked, password was same as username. Cool, thanks man. It's that way for every user I guess? Seems good

[–][deleted] 2 insightful - 2 fun2 insightful - 1 fun3 insightful - 2 fun -  (15 children)

sweet. the new default for new users is a random password, but for existing accounts like yours the default is the username. We'll manually update your account sometime so you have a secure chat password.

[–]magnora7[S] 1 insightful - 1 fun1 insightful - 0 fun2 insightful - 1 fun -  (14 children)

Ah ok, cool. We should give users their passwords in case they get logged out like me. If you want to go back to username=password that's fine by me, then we don't have to send out automated messages with passwords and all that stuff. Plus they can change it if they like, as you said. My 2 cents. But I can see the security issues too, so your change makes sense.

Whatever you think works best is fine, but people should at least have access to their passwords in case they get accidentally logged out like I did, however you want to accomplish that.

[–][deleted] 2 insightful - 2 fun2 insightful - 1 fun3 insightful - 2 fun -  (13 children)

Agreed. Try registering with a new account and you will see a default random password. So only you and I have this weird alternate password or a blank password. So I think nothing to do here.

[–]magnora7[S] 2 insightful - 1 fun2 insightful - 0 fun3 insightful - 1 fun -  (0 children)

Ah I see it now, under 'preferences' on reddit next to my reddit username. With your nice instructions

[–]magnora7[S] 1 insightful - 1 fun1 insightful - 0 fun2 insightful - 1 fun -  (0 children)

Sorry but where do they see the password exactly?

[–]magnora7[S] 1 insightful - 1 fun1 insightful - 0 fun2 insightful - 1 fun -  (10 children)

This is unrelated, but I just spent an hour trying to figure out how to change the default subreddits for new users, and I'm having a lot of trouble for something that seems like it would be simple. I thought it'd be in that development.update file or something, or maybe in the reddit UI, but I can't find it anywhere.

The inject_test_data.py has a line that defines the defaults, which is the only place in all the files where I can find a mention of "askhistorians", which is currently a default sub:

srs = [Subreddit._by_name(n) for n in ("pics", "videos", "askhistorians")]

LocalizedDefaultSubreddits.set_global_srs(srs)

So maybe we can just put that line in another python file somewhere and run it with a new list or something. Is that the way to update the defaults? Seems weird. Any ideas where to put or run this code? Is this best done in the command-line by running a small custom python file or something? I just don't get exactly how to make it happen, if you've got any ideas to try I'm all ears... I don't get where the actual list is stored or how to correctly write to that place, I guess it's in the postgresql database?

[–]magnora7[S] 1 insightful - 1 fun1 insightful - 0 fun2 insightful - 1 fun -  (8 children)

Maybe subreddit settings should have more options too, like sidebar chat on/off, post and comments chat on/off

Yeah I think this definitely needs to happen. I'll start looking in to it.

Quick question, does the site load slow on mobile for you? I got rid of the banner for mobile, but it still goes very slow on my phone. Is it also that way on your phone browser?

[–][deleted] 2 insightful - 1 fun2 insightful - 0 fun3 insightful - 1 fun -  (7 children)

It seems to work okay on my phone. We do have an open css issue though, the browser is merging less files into css (like a dev mode thing), rather than the server. Once we fix that it should load a bit faster.

Maybe your chat client is connected to a lot of rooms too... that might appear to slow down the page load.

[–]magnora7[S] 1 insightful - 1 fun1 insightful - 0 fun2 insightful - 1 fun -  (6 children)

Sounds great. The phone loads very slow for me on pages without chat, and my friend had the same problem on his phone. I think there's some extra code for mobile that is being activated with iphone perhaps that stalls. It takes me like 30 seconds to load each page because it always hangs in the start, and I'm on the same router as my computer where it loads fine. Not a huge deal, but I'm going to keep looking around, I think they're running some location tracking software with mobile or something that I will disable

[–][deleted] 1 insightful - 2 fun1 insightful - 1 fun2 insightful - 2 fun -  (5 children)

ugh that sounds bad. have never tried with iphone. i will look into this.

[–]magnora7[S] 1 insightful - 1 fun1 insightful - 0 fun2 insightful - 1 fun -  (4 children)

Yeah it just hangs in the beginning... other websites load fine, and it also does this on 4G so I know it's the phone, and not the website or the connection. I'm digging through their "if mobile then..." code, because it looks like there is a lot of crap that simply doesn't need to be there. It honestly seems like it's triggering some request that sits and waits until it times out. If I can just shorten that timeout, or get rid of the request that is apparently only triggered on my phone, then we can fix it. I'm looking in to it.

[–][deleted] 2 insightful - 2 fun2 insightful - 1 fun3 insightful - 2 fun -  (1 child)

Yeah that sounds reasonable, good luck. I wish reddit was a normal responsive site without the alternate mobile templates. Oh well. We can put work into the mobile version too.

[–]magnora7[S] 2 insightful - 1 fun2 insightful - 0 fun3 insightful - 1 fun -  (0 children)

Yeah it sucks that it's designed that way. Seems like with how powerful phones are though we don't need a mobile version. So I'd just like to merge the two, and just make it work smoother on mobile. We'll just have to play with it and see what works

[–][deleted] 2 insightful - 2 fun2 insightful - 1 fun3 insightful - 2 fun -  (1 child)

on my girlfriends iphone 6 the site loaded fine, even into chat. so I would try clearing all of your cache and cookies on mobile. also try logging out of the site and repeating. maybe something still has the old ssl cert cached.

[–]magnora7[S] 1 insightful - 1 fun1 insightful - 0 fun2 insightful - 1 fun -  (0 children)

Awesome, that's great news. I am using an old version of IOS too, so that's probably the reason. My friend just tried it on his android phone and it worked fine. So I'm going to say the mobile speed issue is solved

[–]magnora7[S] 1 insightful - 1 fun1 insightful - 0 fun2 insightful - 1 fun -  (1 child)

Last comment: It is working fine in incognito mode, but i'm still logged out of the lounge in every chat window in my non-incognito browser and I don't know the username and password. Also if I log in as magnora7 in incognito, it logs me out of the lounge again. Did I break lounge policies or something?

[–][deleted] 1 insightful - 2 fun1 insightful - 1 fun2 insightful - 2 fun -  (0 children)

When logged in, inspect the iframe src parameter "al-password", this is what it's sending to the lounge client. I think yours should be or was the old default "magnora7". This password is locked to the username the first time it is used and can't be changed.. ill have to improve the docs or make the IRC password field read only.

If you did change the password, after changing it back you probably have to run sudo reddit-flush which flushes all caches and will make the template/iframe use your updated password.

We can manually reset irc client accounts too if we need to, but there's only a command line interface for that... you can start over for your account by deleting ~/.lounge/users/magnora7.json

(at which point the first password sent is the new password)