Spoiler test by wizzwizz4 in wizzwizz4_css_test_1

[–][deleted] 1 insightful - 1 fun1 insightful - 0 fun2 insightful - 1 fun -  (0 children)

test [SPOILER] blabla

Spoiler test by wizzwizz4 in wizzwizz4_css_test_1

[–][deleted] 1 insightful - 1 fun1 insightful - 0 fun2 insightful - 1 fun -  (0 children)

wtf just happend, i got duzzy SPOILER rhh what, are you facking russians shitting again

Spoiler test by wizzwizz4 in wizzwizz4_css_test_1

[–]wizzwizz4[S] 1 insightful - 1 fun1 insightful - 0 fun2 insightful - 1 fun -  (0 children)

An actual thumbnail test this time. by wizzwizz4 in wizzwizz4_css_test_1

[–]wizzwizz4[S] 1 insightful - 1 fun1 insightful - 0 fun2 insightful - 1 fun -  (0 children)

Well, ****. That's a rubbish way for it to work, and whoever designed that is an idiot. (Yes, I'm well aware that the client-side code I wrote works exactly the same way, and that there are good reasons for it… shut up, me.)

Testing image coolness and lols – how does the Preview / Thumbnail system function? by wizzwizz4 in wizzwizz4_css_test_1

[–]wizzwizz4[S] 1 insightful - 1 fun1 insightful - 0 fun2 insightful - 1 fun -  (0 children)

Ok, but you didn't actually test it here. Try again.

Spoiler test by wizzwizz4 in wizzwizz4_css_test_1

[–]wizzwizz4[S] 1 insightful - 2 fun1 insightful - 1 fun2 insightful - 2 fun -  (0 children)

Hmm… test. Oh, phew!

JS SVG test by wizzwizz4 in wizzwizz4_css_test_1

[–]wizzwizz4[S] 2 insightful - 2 fun2 insightful - 1 fun3 insightful - 2 fun -  (0 children)

I don't know if this would be an acceptable alternative to 3…

If a user is not signed in, preferences are read from and stored to cookies.

JS SVG test by wizzwizz4 in wizzwizz4_css_test_1

[–]magnora7 2 insightful - 1 fun2 insightful - 0 fun3 insightful - 1 fun -  (0 children)

Use for gore, like the shooting video that was here yesterday. I want the listing to show up on /r/all, yes.

Those feature requests seem adequately possible-but-non-trivial to outsource.

Yeah that's basically how I feel about them which is why I haven't really been trying to put these features out there because I'm not sure anyone will take the time because it's really not too easy.

If you happen to make any progress, let me know!

JS SVG test by wizzwizz4 in wizzwizz4_css_test_1

[–]wizzwizz4[S] 1 insightful - 1 fun1 insightful - 0 fun2 insightful - 1 fun -  (0 children)

For 3, by "in listings" I assume you aren't counting /s/all. Although I'm struggling to see what the NSFW tag would be used for in the first place, if not porn. (On second thoughts, I don't think I want to know.)

Those feature requests seem adequately possible-but-non-trivial to outsource. I might have a stab at 2, if I find the time.

JS SVG test by wizzwizz4 in wizzwizz4_css_test_1

[–]magnora7 2 insightful - 1 fun2 insightful - 0 fun3 insightful - 1 fun -  (0 children)

That's not a bad idea. We might start doing this. I'll have to look through the to-do list though and see what's left.

Tbh we've already solved most of the small bugs. Feature requests would definitely be a good idea though, no security risk there.

Here's 3 features we're going to work on very soon, if you (or anyone else wants to help)

  1. The "unsubscribe to all subs" button that is currently in user preferences, also put that on the user sub management page

  2. The algorithm for limiting how frequently new users can post and comment is too strict and we want to loosen it slightly by allowing for several more posts to be made before the "You are doing this too much, wait 9 mins" dialog comes up.

  3. NSFW posts do not appear in the listings for users not logged in. We want to change it so they do appear for everyone (but the thumbnail will still be fuzzed out)

Those 3 are basically my little projects for the next few days, but if you or anyone wants to take a stab at them, by all means...

I might make this a more official announcement for everyone to see. This is a pretty good idea. Thanks!

JS SVG test by wizzwizz4 in wizzwizz4_css_test_1

[–]wizzwizz4[S] 1 insightful - 1 fun1 insightful - 0 fun2 insightful - 1 fun -  (0 children)

Post the small bugs and the feature-requests; they'll be done in no time.

JS SVG test by wizzwizz4 in wizzwizz4_css_test_1

[–]magnora7 1 insightful - 1 fun1 insightful - 0 fun2 insightful - 1 fun -  (0 children)

We have a huge to-do list we've been working off of for over a year, but it's visible to the admins only. The problem with putting all our bugs on display is that it might open us up to attacks and give trolls ammo to mess with the site.

JS SVG test by wizzwizz4 in wizzwizz4_css_test_1

[–]wizzwizz4[S] 1 insightful - 1 fun1 insightful - 0 fun2 insightful - 1 fun -  (0 children)

Adding your wishlist to GitHub Issues, and maybe setting up a Project Board or two would help to permit contributions.

JS SVG test by wizzwizz4 in wizzwizz4_css_test_1

[–]magnora7 2 insightful - 1 fun2 insightful - 0 fun3 insightful - 1 fun -  (0 children)

Wow that's great! I love it when other users contribute code and add more functionality. I thanked them for it, that's awesome

JS SVG test by wizzwizz4 in wizzwizz4_css_test_1

[–]magnora7 1 insightful - 1 fun1 insightful - 0 fun2 insightful - 1 fun -  (0 children)

Hey nice coding wizzwizz, solid job! Very much appreciate the added functionality, and I'm sure the users will too. Thank you. We're proud to have more code contributions to the site by users like you.

JS SVG test by wizzwizz4 in wizzwizz4_css_test_1

[–][deleted] 2 insightful - 1 fun2 insightful - 0 fun3 insightful - 1 fun -  (0 children)

Nice work! Supporting more url formats was a boss change too. I'll get around to adding this same image support for saidit posts proper too.

/u/magnora7 check it out the wizz added .svg support.

https://dev.w3.org/SVG/tools/svgweb/samples/svg-files/mudflap.svg

https://dev.w3.org/SVG/tools/svgweb/samples/svg-files/json.svg

You can embed rasters in vectors? Hmm..

https://dev.w3.org/SVG/tools/svgweb/samples/svg-files/image.svg

JS SVG test by wizzwizz4 in wizzwizz4_css_test_1

[–]wizzwizz4[S] 3 insightful - 1 fun3 insightful - 0 fun4 insightful - 1 fun -  (0 children)

That'd be great; I can't actually find it right now (assuming it's Python).

Edit: https://github.com/libertysoft3/saidit/blob/master/r2/r2/public/static/js/expando-md.js

Edit #2: https://github.com/libertysoft3/saidit/pull/9

JS SVG test by wizzwizz4 in wizzwizz4_css_test_1

[–][deleted] 1 insightful - 1 fun1 insightful - 0 fun2 insightful - 1 fun -  (0 children)

Alright, it's on our Todo list. I'll show you where the relevant code is if you're so inclined.

JS SVG test by wizzwizz4 in wizzwizz4_css_test_1

[–]wizzwizz4[S] 1 insightful - 1 fun1 insightful - 0 fun2 insightful - 1 fun -  (0 children)

So, add? (Please please please?) 🥺

JS SVG test by wizzwizz4 in wizzwizz4_css_test_1

[–][deleted] 1 insightful - 1 fun1 insightful - 0 fun2 insightful - 1 fun -  (0 children)

It looks like you're right, no internal js is run if rendered as an <img>

JS SVG test by wizzwizz4 in wizzwizz4_css_test_1

[–]wizzwizz4[S] 2 insightful - 1 fun2 insightful - 0 fun3 insightful - 1 fun -  (0 children)

That's expected. But does it run in Chrome in an <img /> tag? I tested it and it didn't, so there should be no problem with including SVGs.

JS SVG test by wizzwizz4 in wizzwizz4_css_test_1

[–][deleted] 1 insightful - 1 fun1 insightful - 0 fun2 insightful - 1 fun -  (0 children)

Oh, iframe is a good idea. Yeah the js runs for me in Chrome once I leave the site and view it.

JS SVG test by wizzwizz4 in wizzwizz4_css_test_1

[–]wizzwizz4[S] 1 insightful - 1 fun1 insightful - 0 fun2 insightful - 1 fun -  (0 children)

In <img / > tags Firefox ignores the JavaScript. Is that the same in Chrome? You can use my example to test. (Don't worry; it doesn't mine crypto or use Meltdown to GET U.)

Otherwise, you can just display the image in an <iframe></iframe>.

JS SVG test by wizzwizz4 in wizzwizz4_css_test_1

[–][deleted] 1 insightful - 1 fun1 insightful - 0 fun2 insightful - 1 fun -  (0 children)

Yeah we can't render svg here without stripping js, especially these days.

JS SVG test by wizzwizz4 in wizzwizz4_css_test_1

[–]wizzwizz4[S] 1 insightful - 1 fun1 insightful - 0 fun2 insightful - 1 fun -  (0 children)

Huh. When an SVG-with-JavaScript is included in an img tag, the JavaScript doesn't run.

Spoiler test by wizzwizz4 in wizzwizz4_css_test_1

[–]wizzwizz4[S] 2 insightful - 1 fun2 insightful - 0 fun3 insightful - 1 fun -  (0 children)

Failed. Inline spoiler markup, e.g.

>!test succeeded!< (`>!test succeeded!<`)

currently causes an Error 500.

Spoiler test by wizzwizz4 in wizzwizz4_css_test_1

[–]Mnemonic 1 insightful - 1 fun1 insightful - 0 fun2 insightful - 1 fun -  (0 children)

! test failed, or not? !