you are viewing a single comment's thread.

view the rest of the comments →

[–]portcity[S] 2 insightful - 1 fun2 insightful - 0 fun3 insightful - 1 fun -  (3 children)

Hi! How are you? Everything is going well. I tried out some of 0eye's changes (which you can see at portcity.online , daymode). Can you tell me where in the files I can change the Saidit logo in the top banner and the little icons that appear when links don't surface an image? I know what I'm doing probably still looks very clumsy to you, but remember I was a complete noob at unix before I started working away at the reddit codebase, so I feel like all things considered I've come a long way (thanks to your help).

[–]d3rr 1 insightful - 1 fun1 insightful - 0 fun2 insightful - 1 fun -  (2 children)

Hey there. Glad you're excited. You can find all of that stuff in reddit.less and theme-custom.less. You can find images by searching for their filenames.

I recommend only making changes using overrides in theme-custom.less so they are all in one spot and you can get updates from us.

[–]portcity[S] 1 insightful - 1 fun1 insightful - 0 fun2 insightful - 1 fun -  (1 child)

Ok, I successfully replaced the Saidit logo with a PortCity logo I made in like 5 minutes with this command: $ scp /Users/user/Downloads/portcitylogo.png reddit@x.x.x.x:/home/reddit/src/reddit/r2/r2/public/static/saiditlogo.png

And by looking at the saiditlogo.png file in ranger, I can tell it's the new logo I made now.

And then I did the css refresh, but the logo hasn't changed on my site. Any thoughts?

Also I'm a little confused as to what you mean by "making overrides in theme-custom.less." I did undo all the changes I made in daymode.less, because i understand what you mean about wanting to get updates from you. But how do I use overrides to make changes going forward?

[–]d3rr 1 insightful - 1 fun1 insightful - 0 fun2 insightful - 1 fun -  (0 children)

I see it! Maybe it's your browser cache. Just pop open the inspector and make sure 'Disable Cache' is checked when you work on it.

But how do I use overrides to make changes going forward?

Feel free to ignore this, but I recommend that you just only add new lines of CSS to the bottom of whatever .less files you want. Then if we change our styles earlier in the file, 'git pull' will still be able to merge the files, and your styles will remain intact.

So no editing, only adding at the bottom. You can copy and paste to the bottom all you want. It bloats the CSS files a bit, but dealing with CSS conflicts is no fun.