you are viewing a single comment's thread.

view the rest of the comments →

[–]magnora7[S] 2 insightful - 1 fun2 insightful - 0 fun3 insightful - 1 fun -  (6 children)

c.user.pref_sendreplies

Do we have to create this first somewhere?

pref_post_sends_replies=VBoolean("post_sends_replies"),

has to be added to the top of newlink.html or something then? Doesn't that need to be in a python file?

[–][deleted] 2 insightful - 1 fun2 insightful - 0 fun3 insightful - 1 fun -  (5 children)

Do we have to create this first somewhere?

Yes, see here https://github.com/libertysoft3/reddit-ae/blob/88b6edc4e2361a903215ed57ce4767043f4ef5c3/r2/r2/models/account.py#L166

pref_post_sends_replies=VBoolean("post_sends_replies"),

I don't think we need this at all, this is only to validate form input for the preferences page. "post_sends_replies" would be the form field name, but it doesn't exist.

[–]magnora7[S] 3 insightful - 1 fun3 insightful - 0 fun4 insightful - 1 fun -  (4 children)

Oh okay. See you in chat

[–][deleted] 2 insightful - 1 fun2 insightful - 0 fun3 insightful - 1 fun -  (3 children)

alright this feature is live and appears to be working https://github.com/libertysoft3/reddit-ae/commit/a911826c6939a7ab6b63955435cabb4c49e2dc7e edit: I didn't tell Orangutan go for it.

[–]magnora7[S] 3 insightful - 1 fun3 insightful - 0 fun4 insightful - 1 fun -  (2 children)

Nice! I tested it out and it works! I'll let him know.

[–][deleted] 3 insightful - 1 fun3 insightful - 0 fun4 insightful - 1 fun -  (1 child)

Sweet, I feel like we've gotten over a little dry spell, starting with your sorting changes.

I also think I mislead you a bit last night by talking about that checkbox field which we didn't end up changing at all, so sorry about that. I was confusing it with the new post page checkbox.

[–]magnora7[S] 3 insightful - 1 fun3 insightful - 0 fun4 insightful - 1 fun -  (0 children)

No worries, we got there in the end. Nice work.