Translations are half-broken

submitted by macadoum from self.SaidIt

sorted by:
top
newinsightfulfun
you are viewing a single comment's thread.

view the rest of the comments →

[–][deleted] 1 insightful - 1 fun1 insightful - 0 fun2 insightful - 1 fun -  (7 children)

Here's the repo https://github.com/libertysoft3/reddit-i18n

[–]macadoum[S] 3 insightful - 1 fun3 insightful - 0 fun4 insightful - 1 fun -  (6 children)

1)Thanks u/d3rr, I missed this repo. According to this commit there is only 11 translations to add at the end. Is it correct ?

2)The problem is that at lot of strings seems to be hardcoded, for exemple in the user preferences panel in prefoptions.html Also, the Find popular subs/find new subs seems to be hardcoded in menu.py

I don't know how easy it could be translated.

[–][deleted] 2 insightful - 1 fun2 insightful - 0 fun3 insightful - 1 fun -  (5 children)

Yes we've only done 11 German translations so far.

Every string you see inside of an underscore function (_("translatable")) is translatable, which includes the examples you've provided. If you see any we've missed, we're happy to fix it.

[–]macadoum[S] 3 insightful - 1 fun3 insightful - 0 fun4 insightful - 1 fun -  (4 children)

Ok u/d3rr and u/magnora7, so how can I help to translate the underscore strings ? I don't know how to do what in github as there is no exemple I can follow. I can just do what u/magnora7 suggested and translate it here, in comment.

[–]magnora7 1 insightful - 1 fun1 insightful - 0 fun2 insightful - 1 fun -  (0 children)

You can literally just give us the "before" and "after" of each string and we can figure out the rest.

We don't have a nice system to input new translations, unfortunately. Reddit had an actual website where you could directly input new translations in to their system.

[–][deleted] 1 insightful - 1 fun1 insightful - 0 fun2 insightful - 1 fun -  (2 children)

you can do it just like your last pull request, if the "msgid" is already defined. If it's not, just add the default/english version of any underscore function string here:

https://github.com/libertysoft3/reddit-i18n/blob/master/reddit_i18n/en/LC_MESSAGES/r2.po#L10388

And then you can translate it in another language file. I'm happy to assist further or explain more if that wasn't clear. Thanks for your efforts.

[–]macadoum[S] 2 insightful - 1 fun2 insightful - 0 fun3 insightful - 1 fun -  (1 child)

Ok, I think I understood how it works. I just made a PR as a test : https://github.com/libertysoft3/reddit-i18n/pull/2

Is it good ?

[–][deleted] 1 insightful - 1 fun1 insightful - 0 fun2 insightful - 1 fun -  (0 children)

Yep, it works. Nice.