Translations are half-broken

submitted by macadoum from (self.SaidIt)

I use the french translation in Saidit and I ended up with only half of the UI actually translated. That a sad state, I'd love to get a fully translated and clean french interface.

I'm not a dev but I watched the github and don't really understand how translations work. As I understand it, you're using some kind of external translations package for general use and not specific to SaidIt which explain why only half strings are translated.

Can I help you devs in any way to fully translate it ?

all 19 comments
sorted by:
top
newinsightfulfun

[–]magnora7 2 insightful - 1 fun2 insightful - 0 fun3 insightful - 1 fun -  (10 children)

Yes, if you want to help improve our languages we'd love to hear corrections. Basically you are correct, we got a database for each language, but then we have added and changed a lot of features, and those changes don't have translations, so they just display the English.

If there is a certain part of the page, or area you'd like to focus on, you can send us the english version followed by the matching french wording, and we can input the changes in to the french language pack for saidit and help it be more complete. If you are interested, you can post it right here in response to this comment and we'll take a look at it. We've already done some corrections for the saidit German language pack, so we'd love to help the French language pack be better too.

[–]macadoum[S] 2 insightful - 1 fun2 insightful - 0 fun3 insightful - 1 fun -  (8 children)

I just send a PR in github to update the fr translation : https://github.com/libertysoft3/reddit-i18n/pull/1

[–]magnora7 1 insightful - 1 fun1 insightful - 0 fun2 insightful - 1 fun -  (2 children)

Awesome! Thank you very much! Merci beaucoup!

Paging /u/d3rr, will you please migrate these changes in to our languages database?

[–][deleted] 2 insightful - 1 fun2 insightful - 0 fun3 insightful - 1 fun -  (1 child)

done

[–]magnora7 2 insightful - 1 fun2 insightful - 0 fun3 insightful - 1 fun -  (0 children)

Nice, thank you sir. I'll let them know.

[–][deleted] 1 insightful - 1 fun1 insightful - 0 fun2 insightful - 1 fun -  (3 children)

it's live, thank you.

[–]macadoum[S] 2 insightful - 1 fun2 insightful - 0 fun3 insightful - 1 fun -  (2 children)

I updated it again on GitHub, in you didn't see, it's about the preferences menu. Something strange : I saw a lot of unused strings in prefoptions file and the and the EN i18n file is full of reddit-gold related. Isn't it better to suppress all of this unused strings ?

[–][deleted] 1 insightful - 1 fun1 insightful - 0 fun2 insightful - 1 fun -  (0 children)

Thanks I'll merge it in. I'm not worried about extra strings. Maybe someday we'll clean it up. Also we want to give everyone all gold features, so we might need some of them.

[–][deleted] 1 insightful - 1 fun1 insightful - 0 fun2 insightful - 1 fun -  (0 children)

it's live

[–]magnora7 1 insightful - 1 fun1 insightful - 0 fun2 insightful - 1 fun -  (0 children)

Hi we've just updated the french translations you put up on github into the saidit code! Thanks again!

[–]JasonCarswell 1 insightful - 1 fun1 insightful - 0 fun2 insightful - 1 fun -  (0 children)

Talk to /u/DeuMae who knows a LOT of languages and might help.

[–][deleted] 1 insightful - 1 fun1 insightful - 0 fun2 insightful - 1 fun -  (7 children)

Here's the repo https://github.com/libertysoft3/reddit-i18n

[–]macadoum[S] 3 insightful - 1 fun3 insightful - 0 fun4 insightful - 1 fun -  (6 children)

1)Thanks u/d3rr, I missed this repo. According to this commit there is only 11 translations to add at the end. Is it correct ?

2)The problem is that at lot of strings seems to be hardcoded, for exemple in the user preferences panel in prefoptions.html Also, the Find popular subs/find new subs seems to be hardcoded in menu.py

I don't know how easy it could be translated.

[–][deleted] 2 insightful - 1 fun2 insightful - 0 fun3 insightful - 1 fun -  (5 children)

Yes we've only done 11 German translations so far.

Every string you see inside of an underscore function (_("translatable")) is translatable, which includes the examples you've provided. If you see any we've missed, we're happy to fix it.

[–]macadoum[S] 3 insightful - 1 fun3 insightful - 0 fun4 insightful - 1 fun -  (4 children)

Ok u/d3rr and u/magnora7, so how can I help to translate the underscore strings ? I don't know how to do what in github as there is no exemple I can follow. I can just do what u/magnora7 suggested and translate it here, in comment.

[–]magnora7 1 insightful - 1 fun1 insightful - 0 fun2 insightful - 1 fun -  (0 children)

You can literally just give us the "before" and "after" of each string and we can figure out the rest.

We don't have a nice system to input new translations, unfortunately. Reddit had an actual website where you could directly input new translations in to their system.

[–][deleted] 1 insightful - 1 fun1 insightful - 0 fun2 insightful - 1 fun -  (2 children)

you can do it just like your last pull request, if the "msgid" is already defined. If it's not, just add the default/english version of any underscore function string here:

https://github.com/libertysoft3/reddit-i18n/blob/master/reddit_i18n/en/LC_MESSAGES/r2.po#L10388

And then you can translate it in another language file. I'm happy to assist further or explain more if that wasn't clear. Thanks for your efforts.

[–]macadoum[S] 2 insightful - 1 fun2 insightful - 0 fun3 insightful - 1 fun -  (1 child)

Ok, I think I understood how it works. I just made a PR as a test : https://github.com/libertysoft3/reddit-i18n/pull/2

Is it good ?

[–][deleted] 1 insightful - 1 fun1 insightful - 0 fun2 insightful - 1 fun -  (0 children)

Yep, it works. Nice.