you are viewing a single comment's thread.

view the rest of the comments →

[–]d3rr 2 insightful - 1 funny2 insightful - 0 funny3 insightful - 1 funny -  (3 children)

Ahh I see, I guess it is blue.

Did some testing, it looks like you can chat in two different channels at once in two different browser tabs, but on reload you are put back in the last active channel. So effectively, you can only be in/viewing one channel at a time if you want to be the same chat user.

Also the blue channel list bar is always there... it's just collapsed/hidden if the window is small enough, but the hamburger menu opens it.

I like where you are heading with these use cases. I will do some more thinking and come up with something. I don't think we can make every use case perfect, and we don't want to modify the chat client so much that it can't be upgraded.

[–]magnora7[S] 2 insightful - 1 funny2 insightful - 0 funny3 insightful - 1 funny -  (2 children)

Good points. I'm sure we'll figure something out.

[–]d3rr 2 insightful - 1 funny2 insightful - 0 funny3 insightful - 1 funny -  (1 child)

Updated chat is live!

  1. Your two tab use case is fixed... in the first tab you will see that you joined a new channel, it will pop onto the blue bar channel list, but you will not switch to it. (This will be essential for having sidebar chat, and then a summoned chat in a comment, so you called this one.)

  2. The chat widget now mostly smoothly handles login and logout. Before it would throw a fit and you got stuck as a guest. So this is a new user use case that needed to work, now it does.

Sidebar chat soon! I think i'll keep the code around for the chat in a post thing we have now, just in case, maybe like a megathread chat.

[–]magnora7[S] 2 insightful - 1 funny2 insightful - 0 funny3 insightful - 1 funny -  (0 children)

Fantastic work! I was worried we'd never resolve #1, that's a pretty big deal. I'm super happy to see it work so flawlessly now. Nice job with the second one as well.

Definitely leave the main chat code for now, good idea. I might be wrong, but it'd be cool if we could just expand the "chat_post_enable" command work in posts that aren't announcements, and then also in comments that aren't posts. Perhaps renaming the command to something more general like "live_chat_enable" if possible.

We can have both sidebar and post/comment chat available simultaneously and then get rid of one as people see fit. Or maybe the sidebar chat could be an option to enable in the subreddit settings, eventually.

Anyway, great work! Things are progressing nicely