Block/hide users

submitted by Flesh from self.IdeasForSaidIt

sorted by:
top
newinsightfulfun
you are viewing a single comment's thread.

view the rest of the comments →

[–]magnora7 2 insightful - 1 fun2 insightful - 0 fun3 insightful - 1 fun -  (10 children)

Cool, nice work. You can mark the github job about the image expansion as finished, too. If you didn't already :)

[–][deleted] 2 insightful - 1 fun2 insightful - 0 fun3 insightful - 1 fun -  (9 children)

Will do. I dislike some of your CSS changes but we'll see what happens. I think they regress mobile, I can fix them in the responsive styles.

[–]magnora7 2 insightful - 1 fun2 insightful - 0 fun3 insightful - 1 fun -  (8 children)

If you want to walk some of my changes back that’s ok. The comment css does seem a little finicky. But the post expands code is good I think. We’re at least in the ballpark

[–][deleted] 2 insightful - 1 fun2 insightful - 0 fun3 insightful - 1 fun -  (7 children)

Well I made some adjustments to the CSS that had the expandos not resizing well all day, sorry about that. Anyway it's fixed now and all of the different use cases seem to be working well, like that image in the sidebar. If you could re-test and make sure it's acting the same as how you had it that'd be cool.

Also, an idea about #4 here, the default sub sort for the home page, should it maybe be site-wide instead of just for the home page? If you want to save a click to get away from hot on the home page, then maybe you want to do that elsewhere? It just seems weird to have a home-page only preference. Anyway it could just as easily be that or the original home page only idea, or two new preferences.

Furthermore, if you change the sort away from hot, does the tab order change? Should the default sort's tab always be positioned leftmost?

Just trying to get the github issue dialed in for takeoff https://github.com/libertysoft3/saidit/issues/30

[–]magnora7 2 insightful - 1 fun2 insightful - 0 fun3 insightful - 1 fun -  (6 children)

Cool, thanks for getting the bugs worked out of the image resizing.

Also, an idea about #4 here, the default sub sort for the home page, should it maybe be site-wide instead of just for the home page?

Can you elaborate? I don't follow what you mean. Can you give an example? I think a broader scope would be OK, but I'm just not sure what you mean exactly.

I would leave the tab order alone, that's fine imo.

[–][deleted] 2 insightful - 1 fun2 insightful - 0 fun3 insightful - 1 fun -  (5 children)

So the proposed new feature is "Everytime I go to my home page I am looking at tab 'new'". What about doing this sitewide, "Everytime I visit any sub I am looking at tab 'new'".

[–]magnora7 2 insightful - 1 fun2 insightful - 0 fun3 insightful - 1 fun -  (4 children)

Ah okay. Interesting, thanks for clarifying. Maybe that could be another separate feature next to it? "default sub view" or something? That way they have max choice of what they want.

[–][deleted] 2 insightful - 1 fun2 insightful - 0 fun3 insightful - 1 fun -  (3 children)

Yeah that's what I was thinking. I guess I don't need to second guess it so much, just trying to avoid "But just the home page?" once we launch it. Adding too many preferences is also undesirable though. Hmm.

[–]magnora7 2 insightful - 1 fun2 insightful - 0 fun3 insightful - 1 fun -  (2 children)

Yeah, and it takes up a lot of time to code all the different variations. I'd just keep it simple I guess, and if people say "but just the home page?" then we can care. Unless it's a feature you personally want, then by all means go for it.

Also I'm working on the logo right now, so if it's acting weird it's just me

[–][deleted] 1 insightful - 1 fun1 insightful - 0 fun2 insightful - 1 fun -  (1 child)

:) I did get one 503 error... glad it was on purpose

Agreed, yeah, I'll keep it simple for now.